Skip to content
This repository has been archived by the owner on Aug 12, 2023. It is now read-only.

Fallback for unsupported image types #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fallback for unsupported image types #45

wants to merge 1 commit into from

Conversation

junaidbhura
Copy link
Owner

Checklist:

  • I've read the Contributing page.
  • I've created an issue and referenced it here.
  • My code is tested.
  • My code follows the WordPress code style.
  • My code has proper inline documentation.

Description

Fixes #42

@junaidbhura junaidbhura mentioned this pull request Jan 17, 2021
Closed
5 tasks
FarkasJanos
FarkasJanos reviewed Sep 29, 2021
View reviewed changes
inc/class-core.php
if ( ! empty( $src ) ) {
return array(
'src' => $src[0],
'width' => 0,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These zero values for width and height should be 1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@FarkasJanos FarkasJanos FarkasJanos left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Image filetype check missing
2 participants
@junaidbhura @FarkasJanos