Move "new file" WordPress folder to PHP category #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…add_shortcode, register_activation_hook and register_deactivation_hook.
junichi11
reviewed
Oct 13, 2022
src/org/netbeans/modules/php/wordpress/resources/templates/package-info.java
Show resolved
Hide resolved
junichi11
reviewed
Oct 13, 2022
src/org/netbeans/modules/php/wordpress/resources/templates/package-info.java
Outdated
Show resolved
Hide resolved
|
Could you squash your changes with the proper comment as one commit? |
At the moment calling the "new file" wizard will show WordPress folder on each project type, which doesn't make sense. So I added the specific category where it belongs to, which is "PHP" in this case. So it will only show up in php projects.
Chris2011
force-pushed
the
feature/move-folder-to-php-category
branch
from
686384f
to
bd60fcf
Compare
|
Finally done. I dunno why github shows old commits that are already on master. |
|
At the end I'm fine to checkout master, rename the old branch create a new one with the same name and add my changes again to make it clean. What do you think? |
Looks good to me. Please do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment calling the "new file" wizard will show WordPress folder on each project type, which doesn't make sense. So I added the specific category where it belongs to, which is "PHP" in this case. So it will only show up in php projects. Also I moved the WordPress folder to the PHP folder.