Added gitlab avatar support #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Savitoj Singh <[email protected]>
jwendell
reviewed
Jan 1, 2022
| let _httpSession = new Soup.Session({user_agent: 'jwendell/gnome-shell-extension-timezone'}); | ||
| let url = 'https://gitlab.com/api/v4/avatar?email=%s'.format(this.gitlab); | ||
| let message = new Soup.Message({method: 'GET', uri: new Soup.URI(url)}); | ||
| if (this._gitlabToken) { |
There was a problem hiding this comment.
Where does this field come from?
| let url = 'https://gitlab.com/api/v4/avatar?email=%s'.format(this.gitlab); | ||
| let message = new Soup.Message({method: 'GET', uri: new Soup.URI(url)}); | ||
| if (this._gitlabToken) { | ||
| message.request_headers.append("Authorization", "token " + this._gitlabToken); |
There was a problem hiding this comment.
According to https://docs.gitlab.com/ee/api/#oauth2-tokens should this header be Authorization: Bearer <your_access_token> instead?
|
|
||
| _httpSession.queue_message(message, Lang.bind(this, function(session, message) { | ||
| if (message.status_code != Soup.KnownStatusCode.OK) { | ||
| log('Response code "%d" getting data from gitlab for user email address %s. Got: %s'.format(message.status_code, this.github, message.response_body.data)); |
| if (!this.avatar && p.avatar_url) | ||
| this.avatar = p.avatar_url; | ||
|
|
||
| if (!this.name && p.name) |
There was a problem hiding this comment.
Looking at https://docs.gitlab.com/ee/api/avatar.html it seems the avatar_url is the only field in the response.
Perhaps you could use the /users endpoint and get all fields like we do with github?
| if (!this.name && p.name) | ||
| this.name = p.name; | ||
|
|
||
| if (!this.city && p.location) |
| @@ -29,6 +29,10 @@ | |||
| "type": "string", | |||
| "description": "Gravatar ID (person's email)" | |||
| }, | |||
| "gitlab": { | |||
There was a problem hiding this comment.
perhaps we could make gitlab a struct containing host and email, with host defaulting to gitlab.com? Thus we would support different self-hosted instances of gitlab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GitLab avatar support, merely any addition to the logic but APIs.
Only works for gitlab.com (No self-hosting GitLab avatar support), self-hosting may be using GTK's
prefssettings.Fixes #36
Signed-off-by: Savitoj Singh [email protected]