Name servers should belong to zone they serve #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a best practice, glue record should belong to zone it serves. And records should be the same in dnsZone and edgeDNS edgeDNS: - test.example.com 30 IN NS ns1.test.example.com - ns1.test.example.com 30 IN A 1.1.1.1 k8gb-coredns: - test.example.com 30 IN NS ns1.test.example.com - ns1.test.example.com 30 IN A 1.1.1.1 This commit changes the way NS and Glue records are named in edgeDNS Signed-off-by: Dinar Valeev <[email protected]>
|
@k0da do you plan to continue working on this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a best practice, glue record should belong to zone it serves.
And records should be the same in dnsZone and edgeDNS
edgeDNS:
k8gb-coredns:
This commit changes the way NS and Glue records are named in edgeDNS
Signed-off-by: Dinar Valeev [email protected]