Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the deployment spec for time-logger app in the tutorial docs #2309

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kale-amruta
Copy link
Contributor

Change Overview

The time-logger deployment spec in the tutorial documentation was not valid and was giving error as

The Deployment "time-logger" is invalid: 
* spec.selector: Required value
* spec.template.metadata.labels: Invalid value: map[string]string{"app":"time-logger"}: `selector` does not match template `labels`

The PR adds the required field in the spec

Pull request type

Please check the type of change your PR introduces:

  • 🚧 Work in Progress
  • 🌈 Refactoring (no functional changes, no api changes)
  • 🐹 Trivial/Minor
  • 🐛 Bugfix
  • 🌻 Feature
  • 🗺️ Documentation
  • 🤖 Test

Issues

  • fixes #issue-number

Test Plan

  • 💪 Manual
  • ⚡ Unit test
  • 💚 E2E

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Thanks for submitting this pull request 🎉. The team will review it soon and get back to you.

If you haven't already, please take a moment to review our project contributing guideline and Code of Conduct document.

@infraq infraq added this to In Progress in Kanister Sep 7, 2023
@kale-amruta kale-amruta changed the title modify the deployment for time-logger app in the tutorial docs Modify the deployment spec for time-logger app in the tutorial docs Sep 7, 2023
@@ -44,6 +44,9 @@ application is installed in the ``default`` namespace.
metadata:
name: time-logger
spec:
selector:
matchLabels:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a note before heading Invoking Kanister Actions, that a better/real database example can be found by following https://github.com/kanisterio/kanister/tree/master/examples/.

@PrasadG193
Copy link
Contributor

PrasadG193 commented Nov 20, 2023

@kale-amruta could you please address the review once you get a chance?

Copy link

This PR is marked as stale due to inactivity. Add a new comment to reactivate it.

@github-actions github-actions bot added the stale label Feb 19, 2024
@pavannd1 pavannd1 removed the stale label Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Kanister
In Progress
Development

Successfully merging this pull request may close these issues.

None yet

4 participants