Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add vscode extensions for devcontainer #1334

Merged
merged 1 commit into from
May 20, 2024

Conversation

warjiang
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

re #1332

2. What is the scope of this PR (e.g. component or file name):

add vscode extensions for devcontainer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

rust-analyzer is a very important tool for rust developers, this PR add vscode's rust-analyzer extension which will be very useful for every new beginner.

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

this pr will impove experience for developers, i've tested it locally one more time.

Copy link

github-actions bot commented May 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy
Copy link
Contributor

Peefy commented May 20, 2024

Hello @warjiang

Great Job and thanks for the contribution. Please sign the CLA and DCO, and I will merge this PR.

@warjiang
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

Peefy added a commit to kcl-lang/cla.db that referenced this pull request May 20, 2024
@Peefy Peefy merged commit 4e20703 into kcl-lang:main May 20, 2024
10 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9155611244

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.062%

Totals Coverage Status
Change from base Build 9124126156: 0.0%
Covered Lines: 53694
Relevant Lines: 75559

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants