Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support return list and dict structure from api ListVariable #1349

Merged
merged 2 commits into from
May 22, 2024

Conversation

zong-zhe
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@zong-zhe zong-zhe added the enhancement New feature or request label May 22, 2024
@zong-zhe zong-zhe added this to the v0.9.0 Release milestone May 22, 2024
@zong-zhe zong-zhe requested a review from Peefy May 22, 2024 09:43
@zong-zhe zong-zhe self-assigned this May 22, 2024
@Peefy Peefy merged commit f90939f into kcl-lang:main May 22, 2024
8 of 10 checks passed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 9189451722

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 116 of 134 (86.57%) changed or added relevant lines in 3 files are covered.
  • 91 unchanged lines in 8 files lost coverage.
  • Overall coverage decreased (-0.02%) to 71.076%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/query/src/selector.rs 73 91 80.22%
Files with Coverage Reduction New Missed Lines %
kclvm/ast/src/token.rs 1 58.9%
kclvm/ast/src/ast.rs 2 83.51%
kclvm/sema/src/core/symbol.rs 3 47.18%
kclvm/ast/src/config.rs 7 0.0%
kclvm/query/src/selector.rs 7 81.3%
kclvm/tools/src/LSP/src/hover.rs 12 90.0%
kclvm/tools/src/LSP/src/completion.rs 24 89.17%
kclvm/sema/src/ty/mod.rs 35 77.32%
Totals Coverage Status
Change from base Build 9177105510: -0.02%
Covered Lines: 53874
Relevant Lines: 75798

💛 - Coveralls

@zong-zhe zong-zhe deleted the support-sub-items branch June 12, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants