Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade dict type into schema type #1350

Merged
merged 9 commits into from
May 24, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented May 22, 2024

upgrade dict type into schema type in node_ty_map if expr's expected type is schema

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/sema/src/advanced_resolver/node.rs
kclvm/sema/src/resolver/node.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

kclvm/sema/src/resolver/config.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/config.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/config.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/resolver/ty.rs Show resolved Hide resolved
@Peefy
Copy link
Contributor

Peefy commented May 22, 2024

Add some comments and grammar test failed in CI.

@He1pa He1pa force-pushed the upgrade_dict_to_schema_ty branch from 48e7705 to f3603e0 Compare May 22, 2024 11:59
kclvm/sema/src/advanced_resolver/node.rs Outdated Show resolved Hide resolved
kclvm/sema/src/advanced_resolver/node.rs Outdated Show resolved Hide resolved
@He1pa He1pa force-pushed the upgrade_dict_to_schema_ty branch from 038bffe to 3b08dbe Compare May 24, 2024 05:15
@coveralls
Copy link
Collaborator

coveralls commented May 24, 2024

Pull Request Test Coverage Report for Build 9219335168

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 185 of 191 (96.86%) changed or added relevant lines in 8 files are covered.
  • 4 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 71.192%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/sema/src/resolver/node.rs 51 52 98.08%
kclvm/sema/src/resolver/ty.rs 94 99 94.95%
Files with Coverage Reduction New Missed Lines %
kclvm/sema/src/resolver/ty.rs 1 77.63%
kclvm/sema/src/core/symbol.rs 3 46.99%
Totals Coverage Status
Change from base Build 9218246731: 0.04%
Covered Lines: 54028
Relevant Lines: 75891

💛 - Coveralls

Signed-off-by: he1pa <[email protected]>
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Peefy Peefy merged commit 1a83c61 into kcl-lang:main May 24, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants