Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes for Invalid Syntax #1367

Closed

Conversation

shashank-iitbhu
Copy link
Contributor

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

fixes from #1360 (comment)

2. What is the scope of this PR (e.g. component or file name):

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other
Screen.Recording.2024-05-27.at.8.10.10.PM.mov

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Signed-off-by: Shashank Mittal <[email protected]>
@Peefy
Copy link
Contributor

Peefy commented May 27, 2024

I've refactored the code in this PR: #1365 You can rebase the main branch and continue working based on this PR.

@shashank-iitbhu
Copy link
Contributor Author

I've refactored the code in this PR: #1365 You can rebase the main branch and continue working based on this PR.

Thanks, just saw this PR.

@Peefy
Copy link
Contributor

Peefy commented May 27, 2024

I've refactored the code in this PR: #1365 You can rebase the main branch and continue working based on this PR.

Thanks, just saw this PR.

No, I'd mean use the parse error definition in the kclvm_error crate instead of defining constants. Besides, I have fixed all the issues with the previous PR, so you don't need to make any further modifications to this PR. If you need to add a new quick fix action, please open a new PR.

I'll close this PR.

@Peefy Peefy closed this May 27, 2024
@shashank-iitbhu
Copy link
Contributor Author

I've refactored the code in this PR: #1365 You can rebase the main branch and continue working based on this PR.

Thanks, just saw this PR.

No, I'd mean use the parse error definition in the kclvm_error crate instead of defining constants. Besides, I have fixed all the issues with the previous PR, so you don't need to make any further modifications to this PR. If you need to add a new quick fix action, please open a new PR.

I'll close this PR.

Understood, will open another PR for adding new fixes.👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants