Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: lsp completion for external pkg in kcl.mod #1448

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

He1pa
Copy link
Contributor

@He1pa He1pa commented Jun 27, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

2. What is the scope of this PR (e.g. component or file name):

kclvm/tools/src/LSP/src/completion.rs

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@He1pa He1pa self-assigned this Jun 27, 2024
@He1pa He1pa added the lsp label Jun 27, 2024
Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9692290017

Details

  • 208 of 215 (96.74%) changed or added relevant lines in 7 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 134 136 98.53%
kclvm/driver/src/lib.rs 12 17 70.59%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/completion.rs 12 91.6%
Totals Coverage Status
Change from base Build 9681379615: 0.03%
Covered Lines: 55963
Relevant Lines: 78302

💛 - Coveralls

@Peefy Peefy merged commit 39cdc71 into kcl-lang:main Jun 27, 2024
12 checks passed
@coveralls
Copy link
Collaborator

coveralls commented Jun 27, 2024

Pull Request Test Coverage Report for Build 9692290017

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 208 of 215 (96.74%) changed or added relevant lines in 7 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 71.471%

Changes Missing Coverage Covered Lines Changed/Added Lines %
kclvm/tools/src/LSP/src/completion.rs 134 136 98.53%
kclvm/driver/src/lib.rs 12 17 70.59%
Files with Coverage Reduction New Missed Lines %
kclvm/tools/src/LSP/src/completion.rs 12 91.6%
Totals Coverage Status
Change from base Build 9681379615: 0.03%
Covered Lines: 55963
Relevant Lines: 78302

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Enhance the completion experience of KCL Import for both internal and external packages
3 participants