Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate proof of work #33

Merged

Conversation

Xavek
Copy link
Contributor

@Xavek Xavek commented Aug 6, 2024

WIP. I have doubts regarding my approach toward porting the Cairo zero function. I would ask the author to review my draft pr afterward would add the test cases.

Note: When pr #15 gets merged or gets into the final stage. Update the proof_of_work function to compute the target.

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
raito ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 2:59pm

@Xavek Xavek changed the title impl proof of work validate func feat: validate proof of work Aug 6, 2024
Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If in doubt, ask questions on project tg group.

src/validation.cairo Outdated Show resolved Hide resolved
src/validation.cairo Outdated Show resolved Hide resolved
src/validation.cairo Outdated Show resolved Hide resolved
@Xavek Xavek marked this pull request as ready for review August 7, 2024 13:23
@Xavek Xavek requested a review from m-kus as a code owner August 7, 2024 13:24
@Xavek Xavek requested a review from maciejka August 7, 2024 13:24
@Xavek
Copy link
Contributor Author

Xavek commented Aug 7, 2024

@maciejka couldn't find the telegram group link in readme

@maciejka
Copy link
Collaborator

maciejka commented Aug 7, 2024

@maciejka couldn't find the telegram group link in readme

https://t.me/RaitoStarknet

Copy link
Collaborator

@maciejka maciejka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, except one small issue.

src/validation.cairo Outdated Show resolved Hide resolved
@maciejka
Copy link
Collaborator

maciejka commented Aug 7, 2024

And please resolve conflicts

@maciejka maciejka merged commit 043bff3 into keep-starknet-strange:main Aug 7, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants