Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Implement the function in the market_utils library. #3 #435

Closed
sparqet opened this issue Sep 21, 2023 · 2 comments · Fixed by #463
Closed

Feat: Implement the function in the market_utils library. #3 #435

sparqet opened this issue Sep 21, 2023 · 2 comments · Fixed by #463
Assignees
@Tbelleng
Labels
enhancement New feature or request

Comments

@sparqet
Copy link
Collaborator

sparqet commented Sep 21, 2023

Implement from getMaxPositionImpactFactor function to getExpectedMinTokenBalance in the market_utils library.

Here is MarketUtils.sol
@sparqet sparqet added the enhancement New feature or request label Sep 21, 2023
@Tbelleng
Copy link
Contributor

Can i take this one ?

@AbdelStark
Copy link
Contributor

Can i take this one ?

Yes, assigned to you

@Tbelleng Tbelleng mentioned this issue Sep 29, 2023
Merged
@sparqet sparqet linked a pull request Oct 8, 2023 that will close this issue
Feat: Implement the function in the market_utils library #3 #463
Merged
@sparqet sparqet closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tbelleng Tbelleng

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat: Implement the function in the market_utils library #3 Tbelleng/satoru
3 participants
@sparqet @AbdelStark @Tbelleng