-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle contract commitments for contract without data items #388
fix: handle contract commitments for contract without data items #388
Conversation
Problem: reexecution panics when a contract doesnt have data items Solution: handle the edge case to prevent panics
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add integration test showing the issue was fixed
2005edc
to
b5d131d
Compare
@HermanObst this branch targets gm/no-possible-convertion where I have added two previously failing blocks. The issue came up when I fixed the conversion issue, I had created a new branch thinking it was unrelated. I hope to merge to that PR then merge to main with those tests. Let me know if that works. |
Problem: reexecution panics when a contract doesnt have data items
Solution: handle the edge case to prevent panics
Requires #387 and Moonsong-Labs/pathfinder#2
Issue Number: N/A
Type
Description
Breaking changes?