Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(backend): funkit EU support #101

Merged

Conversation

chloe-tan
Copy link
Contributor

@chloe-tan chloe-tan commented Jul 8, 2024

StarkNet <> Fun.xyz Integration 2

Changelog

  1. Refactor: Install @funkit/api-base package for cleaner funkit api interface interaction
  2. Refactor: Remove big.js package
  3. Feat: New isEu parameter to getFunkitCheckoutQuote and createFunkitStripeCheckout endpoints
  4. Feat: More tests, checks for region-specific quotes

Screenshots

  1. getFunkitStripeCheckoutQuote tests
image
  1. createFunkitStripeCheckout tests
image
  1. getFunkitStripeCheckoutStatus tests
image

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vault ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 8, 2024 8:22pm

@chloe-tan chloe-tan changed the title refactor(backend): funkit eu support refactor(backend): funkit EU support Jul 8, 2024
@chloe-tan chloe-tan changed the title refactor(backend): funkit EU support feat(backend): funkit EU support Jul 8, 2024
Comment on lines +12 to +14
export function pickSourceAssetForCheckout(isEu: boolean, isNy: boolean) {
return isEu ? TOKEN_INFO.ETHEREUM_ETH : isNy ? TOKEN_INFO.POLYGON_MATIC : TOKEN_INFO.POLYGON_USDC
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Region-specific asset selection logic

Copy link
Contributor

@0xChqrles 0xChqrles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xChqrles 0xChqrles merged commit e88bf48 into keep-starknet-strange:main Jul 16, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants