Feat : added safe proxy implementation for all the clients #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crates/l2/starkgate-manager-client/src/clients/starkgate_manager.rs
Outdated
Show resolved
Hide resolved
crates/l2/starkgate-registry-client/src/clients/starkgate_registry.rs
Outdated
Show resolved
Hide resolved
crates/l2/starknet-core-contract-client/src/artifacts/Starknet.json
Outdated
Show resolved
Hide resolved
crates/l2/starknet-core-contract-client/src/clients/sovereign.rs
Outdated
Show resolved
Hide resolved
crates/l2/starknet-token-bridge-client/src/clients/token_bridge.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
let's remove sovereign from everywhere in the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Earlier we were using unsafe proxy for deploying our L1 contracts. Now to be on the better side, the proxy which starknet uses is being introduced here thus giving us two ways to deploy the contract.
deploy_using_safe_proxywill deploy the contracts on L1 using the Proxy contract and setting the proper governors for upgradeability.Issue : #12