API Generator Code for Keras #19523
Closed
API Generator Code for Keras #19523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fchollet
reviewed
Apr 16, 2024
shell/format.sh
Outdated
| @@ -3,6 +3,10 @@ set -Eeuo pipefail | |||
|
|
|||
| base_dir=$(dirname $(dirname $0)) | |||
|
|
|||
| echo "Generating public APIs..." | |||
| python3 "${base_dir}"/api_gen.py | |||
There was a problem hiding this comment.
Upon thinking more about it -- an issue with generating the API in this script is that it takes quite a bit of time, but most of the time it won't be needed (it's only needed when we add new APIs). So it's actually better to have it in a separate script after all.
There was a problem hiding this comment.
Thanks for the feedback. Added shell/api_gen.sh to generate APIs and kept shell/format.sh for Code formatting.
sampathweb
force-pushed
the
api-gen-code
branch
from
0bfc2f3
to
1e79af8
Compare
|
Closing this PR since #19530 is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API Generator Code.