Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SQS Consume should delete the message after use #156

Merged
merged 1 commit into from
May 22, 2023

Conversation

loicmathieu
Copy link
Member

Fixes #155

@tchiotludo tchiotludo merged commit 32c42ef into master May 22, 2023
1 check passed
@loicmathieu loicmathieu deleted the fix/sqs-consume-delete-msg branch May 22, 2023 15:03
@anna-geller
Copy link
Member

I got the chance to QA this and the deletion is working now

however, the pattern from the issue seems worth revisiting in the future

use case: two flows, flow A and B

  • flow A publishes a message to SQS
  • flow B has SQS trigger + a task to consume a message from the same queue. it only starts after A finished. But this flow B will not consume the message from A as you would expect - somehow, this message sent from flow A is lost. instead, it only starts polling and to make it stop, you would need to send another message e.g. by triggering flow A again

so the end result is that you need 2 messages to make this pattern work - one message that would only trigger flow B and another message that would be the actual message that needs to be processed by flow B

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete consumed message from the queue in the SQS Consume task
3 participants