feat: Ceph & other S3-compatible database-based storages are working #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-mulier-p
added
the
kind/breaking-change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes kestra-io/kestra#4160
However, it also introduces a breaking change for Ceph & other S3-compatible database-based storages as we no longer have a leading slash in paths. Minio users are not impacted
Prior to this PR, Namespace files listing was not working as well as CP / MV files.
After this PR, to keep old data working (executions outputs / NS Files), you need to bulk move everything:
s3cmd mv s3://{bucket}// s3://{bucket}/ --recursiveNote that this is done prior to kestra-io/kestra#3933 so a manual migration is needed