Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for more OS #117

Merged

Conversation

Caixetadev
Copy link
Collaborator

This modification introduces logic into the Makefile so that depending on the operating system (OS), the appropriate command is executed to launch the application.

⚠️ It was tested on Linux, the expected output on MacOS is Darwin and the uname -s command does not exist on Windows so I left it in else

@Caixetadev
Copy link
Collaborator Author

Don't merge this pr yet, I'll update it

@kevinanielsen
Copy link
Owner

So far it looks good - Make is problematic on windows anyway, so if it does not work on there, it is not a big problem.

Let me know when this is ready to be merged :)

@Caixetadev
Copy link
Collaborator Author

I think it's OK then

@kevinanielsen kevinanielsen merged commit 4649cf6 into kevinanielsen:main Jan 28, 2024
2 checks passed
@Caixetadev Caixetadev deleted the feature/support-for-more-os branch January 28, 2024 12:04
Caixetadev added a commit to Caixetadev/go-fast-cdn that referenced this pull request Jan 28, 2024
kevinanielsen added a commit that referenced this pull request Jan 30, 2024
* refactor: change folder name

* refactor: page structure

* fix: adding the right module path

* feat: upload multiple files (#116)

* feat: add property 'multiple' to file input

* feat: sends multiple documents or images to api

* fix: show icon for each file being uploaded

* fix: refresh page after uploading all files

* chore: add semicolons

* fix: cards overflow

* chore: add EOF

* fix: prevent file name overflow in card

Co-authored-by: Kevin Nielsen <[email protected]>

* chore: fix indentation

---------

Co-authored-by: Kevin Nielsen <[email protected]>

* feat: support for more OS (#117)

* feat: add support for txt files (#120)

* docs: fix readme link to goreportcard

* chore: fix typos across files (#121)

* Update handleImageResize.go

* fix: successfully typo

* refactor: rename folder

* refactor: remove folder backend

* refactor: move to root

* fix: paths

* build: run go mod tidy

---------

Co-authored-by: Wallys Ferreira <[email protected]>
Co-authored-by: Kevin Nielsen <[email protected]>
Co-authored-by: Kevin Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants