Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for txt files #120

Merged

Conversation

Caixetadev
Copy link
Collaborator

I noticed that when I tried to send a .txt file, it returned an error saying it wasn't supported, even though the map had the option for txt. The issue arose because my file had charset=utf-8, and since there was no corresponding entry in the map, it resulted in an error. I chose not to remove text/plain because there might be files that aren't in utf-8 format.

@kevinanielsen kevinanielsen added api Improvements or additions to the api go Language: Go labels Jan 28, 2024
Copy link
Owner

@kevinanielsen kevinanielsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - thank you!

@kevinanielsen kevinanielsen merged commit 5b1715c into kevinanielsen:main Jan 28, 2024
2 checks passed
@Caixetadev Caixetadev deleted the feature/support-for-text branch January 28, 2024 12:04
Caixetadev added a commit to Caixetadev/go-fast-cdn that referenced this pull request Jan 28, 2024
kevinanielsen added a commit that referenced this pull request Jan 30, 2024
* refactor: change folder name

* refactor: page structure

* fix: adding the right module path

* feat: upload multiple files (#116)

* feat: add property 'multiple' to file input

* feat: sends multiple documents or images to api

* fix: show icon for each file being uploaded

* fix: refresh page after uploading all files

* chore: add semicolons

* fix: cards overflow

* chore: add EOF

* fix: prevent file name overflow in card

Co-authored-by: Kevin Nielsen <[email protected]>

* chore: fix indentation

---------

Co-authored-by: Kevin Nielsen <[email protected]>

* feat: support for more OS (#117)

* feat: add support for txt files (#120)

* docs: fix readme link to goreportcard

* chore: fix typos across files (#121)

* Update handleImageResize.go

* fix: successfully typo

* refactor: rename folder

* refactor: remove folder backend

* refactor: move to root

* fix: paths

* build: run go mod tidy

---------

Co-authored-by: Wallys Ferreira <[email protected]>
Co-authored-by: Kevin Nielsen <[email protected]>
Co-authored-by: Kevin Nielsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Improvements or additions to the api go Language: Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants