Partial admin commit #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsteves
reviewed
Sep 30, 2019
| @@ -171,6 +171,8 @@ def main(): | |||
| kwargs['extra_qs'] = options['ad_hoc'] | |||
| if len(options['vsys']): | |||
| kwargs['vsys'] = options['vsys'][0] | |||
| if len(options['admin']): | |||
There was a problem hiding this comment.
this diff is for type=commit only, not user-id
kevinsteves
reviewed
Sep 30, 2019
| @@ -276,6 +278,8 @@ def main(): | |||
| kwargs['extra_qs'] = options['ad_hoc'] | |||
| if len(options['vsys']): | |||
| kwargs['vsys'] = options['vsys'][0] | |||
| if len(options['admin']): | |||
kevinsteves
reviewed
Sep 30, 2019
| admin = s.split(',') | ||
| for admin in admin: | ||
| if admin: | ||
|
|
kevinsteves
reviewed
Sep 30, 2019
| def get_admin(s): | ||
| list = [] | ||
| admin = s.split(',') | ||
| for admin in admin: |
There was a problem hiding this comment.
this works but prefer something like for admin in admins:
kevinsteves
reviewed
Sep 30, 2019
| @@ -880,6 +902,7 @@ def usage(): | |||
| --override element override template object at xpath | |||
| --vsys vsys VSYS for dynamic update/partial commit/ | |||
| operational command/report | |||
| --admin admin admin for specific update/partial commit | |||
There was a problem hiding this comment.
maybe better is "admins for partial commit"
kevinsteves
reviewed
Sep 30, 2019
| ``--admin`` *admin* | ||
| Specify optional **admin** for partial commit (**--partial** admin). Commits | ||
| only the changes made only by specified administrator accounts. Requires | ||
| PanOS 8.0+. |
There was a problem hiding this comment.
suggest "PAN-OS 8.0 or greater" or "PAN-OS >= 8.0"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add partial admin commit functionality supported in PanOS 8.0+.