-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add sharedvpc support for lb subnet #1280
base: main
Are you sure you want to change the base?
add sharedvpc support for lb subnet #1280
Conversation
|
Welcome @swarren83! |
Hi @swarren83. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
/hold |
/easycla |
@@ -113,6 +118,6 @@ func New(scope Scope) *Service { | |||
regionalhealthchecks: scope.Cloud().RegionHealthChecks(), | |||
instancegroups: scope.Cloud().InstanceGroups(), | |||
targettcpproxies: scope.Cloud().TargetTcpProxies(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that the health checks should be created or found in the VPC Network Project. I am unsure, but the Target TCP Proxies may be too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@barbacbd I updated to include regionalHealthChecks
and targetTCPProxies
. I also updated the tests. I finished signing the CLA and got the confirmation emails, but this PR is still failing on that step.
1ebb54b
to
5492ae7
Compare
/hold cancel |
please sign the cla /ok-to-test |
@cpanato I signed the CLA yesterday and again today. I have received email confirmation both times. It states "This is a notification email from EasyCLA regarding the project OpenTelemetry." According to the docs it doesn't appear that EasyCLA is sending me to the correct agreement. Is there another way to sign the CLA? |
I have opened a support case with LFX Support regarding EasyCLA issues I am experiencing. |
/check-cla |
fix: set cloudScope for regionalhc and tgttcpproxies add test for lb w/ shared vpc add more test cases
5492ae7
to
0f16b9e
Compare
The EasyCLA issue was that I signed with an email address that didn't match the one used to sign the CLA. |
/hold |
@cpanato I need to wait on merging this. I need to work on switching to the Corporate CLA. |
/hold cancel |
@cpanato Ready to proceed if this lgtm. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign @damdo
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, swarren83 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold for @damdo review as well |
What type of PR is this?
What this PR does / why we need it:
Add support for SharedVPC when specifying
spec.loadBalancer.internalLoadBalancer.subnet
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1279
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: