-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ vGPU implementation #3025
base: main
Are you sure you want to change the base?
✨ vGPU implementation #3025
Conversation
Welcome @birksl! |
Hi @birksl. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/easycla |
test/e2e/data/infrastructure-vsphere-govmomi/main/vgpu/kustomization.yaml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the long round-trip between reviews.
Another round of nits then I think this is good!
cc @neolit123 maybe this is interesting for you.
Co-authored-by: Christian Schlotter <[email protected]>
Thanks for the guidance. I learnt a lot :) |
Co-authored-by: Lubomir I. Ivanov <[email protected]>
don't forget to squash all commits before the final merge. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Not needed. We can just use tide to squash (we improved our release notes tool a while ago, so it can handle squash commits now) |
probably the blow scenario will never happen, but note that squash nukes gpg signatures, so some contributor might decide to create a problem. |
/lgtm Thanks @neolit123 for also taking a look! |
LGTM label has been added. Git tree hash: 431e3c4e236991e0ecf51615460596202a7aeb32
|
Builds on the changes in #2272
What this PR does / why we need it:
Support adding vGPUs to VMs
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1972