Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L4 RBS External LB NEG support #2565

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

L4 RBS External LB NEG support #2565

wants to merge 4 commits into from

Conversation

mmamczur
Copy link
Contributor

This PR contains the implementation of NEG variant of the L4 RBS LoadBalancer

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mmamczur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 23, 2024
@mmamczur mmamczur force-pushed the ext_l4_lb_negs branch 2 times, most recently from e6b84dd to 2117076 Compare May 23, 2024 13:49
@mmamczur
Copy link
Contributor Author

/assign @cezarygerard

@mmamczur mmamczur force-pushed the ext_l4_lb_negs branch 3 times, most recently from df95f72 to c9795fc Compare May 24, 2024 11:00
@mmamczur
Copy link
Contributor Author

/assign @swetharepakula
/assign @sawsa307

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
@mmamczur
Add flag for L4 RBS NetLB NEGs.
9abc64c 
Adds `--enable-l4-netlb-neg` that will allow to create NEGs for L4 NetLBs (only opt-in ones)
@mmamczur
NetLBFinalizerV3 for NEG variant of L4 RBS NetLB.
d27d63c 
NetLBFinalizerV3 will be added to the L4 RBS NetLBs that opt-in for NEG support.
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2024
@mmamczur
Copy link
Contributor Author

/unassign @swetharepakula

@mmamczur
Copy link
Contributor Author

/unassign @sawsa307

@mmamczur
Copy link
Contributor Author

/hold

let's not merge this before the next code freeze ends

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels May 29, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mmamczur
NEG Controller support for L4 NetLB.
c6b0781 
When enabled, the NEG controller will create NEGs for L4 RBS NetLBs that opt-in to NEG support.
@mmamczur
L4 RBS External LB NEG support.
d3eab54 
This adds an opt-in mechanism for NEG variant of the NetLB (External LB service)
@k8s-ci-robot
Copy link
Contributor

@mmamczur: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-ingress-gce-test d3eab54 link true /test pull-ingress-gce-test
pull-ingress-gce-verify d3eab54 link true /test pull-ingress-gce-verify
pull-ingress-gce-e2e d3eab54 link true /test pull-ingress-gce-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauravkghildiyal gauravkghildiyal Awaiting requested review from gauravkghildiyal

@sawsa307 sawsa307 Awaiting requested review from sawsa307

Assignees

@cezarygerard cezarygerard

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mmamczur @k8s-ci-robot @swetharepakula @cezarygerard @sawsa307