Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate secrets-store-csi-driver jobs to community cluster #30667

Closed
wants to merge 1 commit into from
Closed

migrate secrets-store-csi-driver jobs to community cluster #30667

wants to merge 1 commit into from

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Sep 10, 2023

This PR moves secrets-store-csi-driver jobs to the community owned EKS cluster. Additionally, updates k8s versions in jobs, removes 1.24 and adds 1.28 job.

ref: #29722

/cc @aramase @nilekhc @ritazh @tam7t

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 10, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 16, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Oct 18, 2023

ping @aramase @nilekhc @ritazh @tam7t
/cc @ameukam

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 19, 2023
@rjsadow
Copy link
Contributor Author

rjsadow commented Nov 12, 2023

ping @aramase @nilekhc @ritazh @tam7t @ameukam

@rjsadow
Copy link
Contributor Author

rjsadow commented Nov 12, 2023

/retest

aramase
aramase suggested changes Nov 30, 2023
View reviewed changes
config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml Outdated
@@ -435,17 +452,21 @@ presubmits:
privileged: true
env:
- name: KUBERNETES_VERSION
value: "1.24.7"
value: "1.25.13"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjsadow could you revert these changes? I would prefer doing these bumps in a separate PR so we can isolate any errors post merge.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml Outdated
Comment on lines 1085 to 1091
resources:
limits:
cpu: 2
memory: 8Gi
requests:
cpu: 2
memory: 8Gi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The requests and limits changes aren't consistent across all jobs in the PR. Should we make it consistent?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated all to 4cpu 6GB memory.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rjsadow
Once this PR has been reviewed and has the lgtm label, please ask for approval from aramase. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rjsadow
Copy link
Contributor Author

rjsadow commented Dec 8, 2023

/retest

@ameukam
Copy link
Member

ameukam commented Jan 15, 2024

@aramase can you PTAL again ? 🙏🏾

aramase
aramase reviewed Jan 16, 2024
View reviewed changes
config/jobs/kubernetes-sigs/secrets-store-csi-driver/secrets-store-csi-driver-config.yaml
@@ -857,6 +890,7 @@ postsubmits:
- aramase
- ritazh
- name: secrets-store-csi-driver-e2e-gcp-postsubmit
cluster: eks-prow-build-cluster
Copy link
Member

@aramase aramase Jan 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gcp jobs are configured to use workload identity with the prow cluster for accessing secrets manager used in CI. Moving it to the eks prow cluster would break this job?

cc @tam7t

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/hold

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aramase @tam7t is that done via the service account?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2024
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 13, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rjsadow rjsadow closed this Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aramase aramase aramase requested changes

@nilekhc nilekhc Awaiting requested review from nilekhc

@ritazh ritazh Awaiting requested review from ritazh

@tam7t tam7t Awaiting requested review from tam7t

@ameukam ameukam Awaiting requested review from ameukam

Assignees

@aramase aramase

Labels
area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rjsadow @k8s-ci-robot @ameukam @aramase