drop gcp-project-type from presubmits #30789

kannon92 · 2023-09-21T19:22:34Z

Moving these periodics to presubmits. I notice that in the presubmit file we don't have gcp-project-type.

Seeing failures in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120679/pull-crio-cgroupv1-node-e2e-eviction/1704873947100614656/

aojea · 2023-09-21T19:57:08Z

what are those failures?

kannon92 · 2023-09-21T20:02:39Z

what are those failures?

I was getting

{  --provider=gce boskos failed to acquire project: resources not found}

W0921 15:12:09.378] (for local runs please set --gcp-project to your dev project)
W0921 15:12:09.378] 2023/09/21 15:07:09 main.go:758: provider gce, will acquire project type node-e2e-project from boskos
W0921 15:12:09.378] 2023/09/21 15:12:09 process.go:96: Saved XML output to /workspace/_artifacts/junit_runner.xml.
W0921 15:12:09.746] 2023/09/21 15:12:09 process.go:153: Running: bash -c . hack/lib/version.sh && KUBE_ROOT=. kube::version::get_version_vars && echo "${KUBE_GIT_VERSION-}"
W0921 15:12:09.746] 2023/09/21 15:12:09 process.go:155: Step 'bash -c . hack/lib/version.sh && KUBE_ROOT=. kube::version::get_version_vars && echo "${KUBE_GIT_VERSION-}"' finished in 368.803239ms
W0921 15:12:09.749] 2023/09/21 15:12:09 main.go:328: Something went wrong: failed to prepare test environment: --provider=gce boskos failed to acquire project: resources not found
W0921 15:12:09.750] Traceback (most recent call last):
W0921 15:12:09.750]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 723, in <module>
W0921 15:12:09.750]     main(parse_args())
W0921 15:12:09.751]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 569, in main
W0921 15:12:09.751]     mode.start(runner_args)
W0921 15:12:09.751]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 228, in start
W0921 15:12:09.751]     check_env(env, self.command, *args)
W0921 15:12:09.751]   File "/workspace/./test-infra/jenkins/../scenarios/kubernetes_e2e.py", line 111, in check_env
W0921 15:12:09.751]     subprocess.check_call(cmd, env=env)
W0921 15:12:09.762]   File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
W0921 15:12:09.762]     raise CalledProcessError(retcode, cmd)
W0921 15:12:09.762] subprocess.CalledProcessError: Command '('kubetest', '--dump=/workspace/_artifacts', '--gcp-service-account=/etc/service-account/service-account.json', '--up', '--down', '--test', '--deployment=node', '--provider=gce', '--cluster=bootstrap-e2e', '--gcp-network=bootstrap-e2e', '--gcp-project-type=node-e2e-project', '--gcp-zone=us-west1-b', '--node-test-args=--container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\\"name\\": \\"crio.log\\", \\"journalctl\\": [\\"-u\\", \\"crio\\"]}"', '--node-tests=true', '--test_args=--nodes=1 --focus="\\[NodeFeature:Eviction\\]"', '--timeout=300m', '--node-args=--image-config-file=/workspace/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv1.yaml')' returned non-zero exit status 1.
E0921 15:12:09.762] Command failed
I0921 15:12:09.763] process 524 exited with code 1 after 5.0m
E0921 15:12:09.763] FAIL: pull-crio-cgroupv1-node-e2e-eviction
I0921 15:12:09.763] Call:  gcloud auth activate-service-account --key-file=/etc/service-account/service-account.json
W0921 15:12:10.601] Activated service account credentials for: [[email protected]]
I0921 15:12:10.717] process 602 exited with code 0 after 0.0m
I0921 15:12:10.717] Call:  gcloud config get-value account
I0921 15:12:11.560] process 612 exited with code 0 after 0.0m
I0921 15:12:11.560] Will upload results to gs://kubernetes-jenkins/pr-logs using [email protected]
I0921 15:12:11.560] Upload result and artifacts...
I0921 15:12:11.560] Gubernator results at https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/120679/pull-crio-cgroupv1-node-e2e-eviction/1704873947100614656
I0921 15:12:11.561] Call:  gsutil ls gs://kubernetes-jenkins/pr-logs/pull/120679/pull-crio-cgroupv1-node-e2e-eviction/1704873947100614656/artifacts
W0921 15:12:12.965] CommandException: One or more URLs matched no objects.
E0921 15:12:13.[182](https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120679/pull-crio-cgroupv1-node-e2e-eviction/1704873947100614656/#1:build-log.txt%3A182)] Command failed

I see logs mention the node-e2e-project but we don't have that project in any of our other presubmits.

aojea · 2023-09-21T20:05:34Z

/assign @BenTheElder

it may be related indeed, but not completely familiar with this setup

kannon92 · 2023-09-21T21:12:41Z

/assign @SergeyKanzhelev

upodroid

Can you move these jobs to the community cluster?

You can do this by adding the field cluster: k8s-infra-prow-build to the job

xref #29722

kannon92 · 2023-09-21T21:44:00Z

Can you move these jobs to the community cluster?

You can do this by adding the field cluster: k8s-infra-prow-build to the job

xref #29722

I looked over and I was only missing one of them.

Converted the periodic crio jobs to use the community cluster. #30793

kannon92 · 2023-09-21T22:14:29Z

/retest

kannon92 · 2023-09-25T16:30:08Z

/retest

SergeyKanzhelev · 2023-09-25T21:25:56Z

does this needs to be rebased now? I am not sure I understand all the differences between projects, but this PR seems incomplete with one job adding cluster and others don't

kannon92 · 2023-09-25T21:36:15Z

does this needs to be rebased now? I am not sure I understand all the differences between projects, but this PR seems incomplete with one job adding cluster and others don't

I rebased earlier today.

I only saw one job in the presubmits that was missing the cluster so I added that.

And the I was told that the gcp-project-type may not be required for the presubmits (#sig-testing help mostly).

kannon92 · 2023-09-25T21:43:55Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

@@ -1134,6 +1134,7 @@ presubmits:
        - '--test-args=--container-runtime-endpoint=unix:///var/run/crio/crio.sock --container-runtime-process-name=/usr/local/bin/crio --container-runtime-pid-file= --kubelet-flags="--cgroup-driver=systemd --cgroups-per-qos=true --cgroup-root=/ --runtime-cgroups=/system.slice/crio.service --kubelet-cgroups=/system.slice/kubelet.service" --extra-log="{\"name\": \"crio.log\", \"journalctl\": [\"-u\", \"crio\"]}"'
        - --image-config-file=/home/prow/go/src/k8s.io/test-infra/jobs/e2e_node/crio/latest/image-config-cgrpv2-k8s-infra-prow-build-kubetest2.yaml
  - name: pull-crio-cgroupv1-node-e2e-features
+    cluster: k8s-infra-prow-build


This is the only job that was missing a cluster tag. All other presubmits have a cluster so they have already been migrated to the community cluster.

kannon92 · 2023-09-25T21:44:19Z

config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

@@ -1161,7 +1162,6 @@ presubmits:
        args:
        - --deployment=node
        - --env=KUBE_SSH_USER=core
-        - --gcp-project-type=node-e2e-project


Not entirely sure why but it seems that presubmits don't require this project-type.

SergeyKanzhelev

/lgtm
/approve

k8s-ci-robot · 2023-09-25T22:10:56Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kannon92, SergeyKanzhelev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~config/jobs/kubernetes/sig-node/OWNERS~~ [SergeyKanzhelev]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot · 2023-09-25T22:31:07Z

@kannon92: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

key sig-node-presubmit.yaml using file config/jobs/kubernetes/sig-node/sig-node-presubmit.yaml

In response to this:

Moving these periodics to presubmits. I notice that in the presubmit file we don't have gcp-project-type.

Seeing failures in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/120679/pull-crio-cgroupv1-node-e2e-eviction/1704873947100614656/

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 21, 2023

k8s-ci-robot requested review from endocrimes and SergeyKanzhelev September 21, 2023 19:22

k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Sep 21, 2023

k8s-ci-robot assigned BenTheElder Sep 21, 2023

k8s-ci-robot assigned SergeyKanzhelev Sep 21, 2023

upodroid reviewed Sep 21, 2023

View reviewed changes

bart0sh added this to Triage in SIG Node PR Triage Sep 25, 2023

bart0sh moved this from Triage to Needs Reviewer in SIG Node PR Triage Sep 25, 2023

kannon92 added 2 commits September 25, 2023 12:08

drop gcp-project-type from presubmits

07751dc

add community cluster

3d7fbf6

kannon92 force-pushed the fix-e2e-eviction-crio branch from bfbcfe6 to 3d7fbf6 Compare September 25, 2023 16:08

kannon92 requested a review from upodroid September 25, 2023 21:34

kannon92 commented Sep 25, 2023

View reviewed changes

SergeyKanzhelev approved these changes Sep 25, 2023

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 25, 2023

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 25, 2023

k8s-ci-robot merged commit a5f8ff0 into kubernetes:master Sep 25, 2023
7 checks passed

SIG Node PR Triage automation moved this from Needs Reviewer to Done Sep 25, 2023

aojea mentioned this pull request Sep 26, 2023

[Failing Test] (ci-crio-cgroupv1-node-e2e-conformance) Failed to prepare test environment kubernetes/kubernetes#120886

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drop gcp-project-type from presubmits #30789

drop gcp-project-type from presubmits #30789

kannon92 commented Sep 21, 2023 •

edited

Loading

aojea commented Sep 21, 2023

kannon92 commented Sep 21, 2023

aojea commented Sep 21, 2023

kannon92 commented Sep 21, 2023

upodroid left a comment

kannon92 commented Sep 21, 2023

kannon92 commented Sep 21, 2023

kannon92 commented Sep 25, 2023

SergeyKanzhelev commented Sep 25, 2023

kannon92 commented Sep 25, 2023

kannon92 Sep 25, 2023

kannon92 Sep 25, 2023

SergeyKanzhelev left a comment

k8s-ci-robot commented Sep 25, 2023

k8s-ci-robot commented Sep 25, 2023

drop gcp-project-type from presubmits #30789

drop gcp-project-type from presubmits #30789

Conversation

kannon92 commented Sep 21, 2023 • edited Loading

aojea commented Sep 21, 2023

kannon92 commented Sep 21, 2023

aojea commented Sep 21, 2023

kannon92 commented Sep 21, 2023

upodroid left a comment

Choose a reason for hiding this comment

kannon92 commented Sep 21, 2023

kannon92 commented Sep 21, 2023

kannon92 commented Sep 25, 2023

SergeyKanzhelev commented Sep 25, 2023

kannon92 commented Sep 25, 2023

kannon92 Sep 25, 2023

Choose a reason for hiding this comment

kannon92 Sep 25, 2023

Choose a reason for hiding this comment

SergeyKanzhelev left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Sep 25, 2023

k8s-ci-robot commented Sep 25, 2023

kannon92 commented Sep 21, 2023 •

edited

Loading