Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate vsphere-csi-driver job to community cluster #31060

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Migrate vsphere-csi-driver job to community cluster #31060

merged 1 commit into from
Oct 23, 2023

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Oct 18, 2023

This PR moves vsphere-csi-driver jobs to the community owned cluster.

ref: #30277

/cc @divyenpatel @SandeepPissay @xing-yang @BaluDontu @deepakkinni
/cc @ameukam

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 18, 2023
@xing-yang
Copy link
Contributor

/retest

@rjsadow
Copy link
Contributor Author

rjsadow commented Oct 20, 2023

ping @xing-yang It looks like tests are good now. Thank you

@xing-yang
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rjsadow, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 585ae7b into kubernetes:master Oct 23, 2023
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key vsphere-csi-driver.yaml using file config/jobs/kubernetes-sigs/vsphere-csi-driver/vsphere-csi-driver.yaml

In response to this:

This PR moves vsphere-csi-driver jobs to the community owned cluster.

ref: #30277

/cc @divyenpatel @SandeepPissay @xing-yang @BaluDontu @deepakkinni
/cc @ameukam

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@divyenpatel
Copy link
Member

@rjsadow jobs started failing after we moved to community cluster.

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-vsphere-csi-driver-deploy/1716549353914503168
https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/post-vsphere-csi-driver-release/1716909085384773632

The pod could not start because it could not mount the volume "cloud-provider-vsphere-e2e-config": secret "cloud-provider-vsphere-e2e-config" not found

In the past we moved to default cluster. Ref PR - #29929

@divyenpatel divyenpatel mentioned this pull request Oct 24, 2023
Merged
@rjsadow
Copy link
Contributor Author

rjsadow commented Oct 24, 2023

@divyenpatel I will revert shortly.

@divyenpatel
Copy link
Member

@rjsadow i have generated PR here - #31116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ameukam ameukam Awaiting requested review from ameukam

@BaluDontu BaluDontu Awaiting requested review from BaluDontu

@deepakkinni deepakkinni Awaiting requested review from deepakkinni

@divyenpatel divyenpatel Awaiting requested review from divyenpatel

@SandeepPissay SandeepPissay Awaiting requested review from SandeepPissay

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@xing-yang xing-yang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rjsadow @xing-yang @k8s-ci-robot @divyenpatel