Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate promo-tools jobs to community cluster #31063

Closed
wants to merge 1 commit into from
Closed

migrate promo-tools jobs to community cluster #31063

wants to merge 1 commit into from

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Oct 18, 2023

This PR moves promo-tools jobs to the community owned cluster.

ref: #30277

/cc @cpanato @jeremyrickard @justaugustus @listx @puerco @saschagrunert
/cc @ameukam

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 18, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rjsadow
Once this PR has been reviewed and has the lgtm label, please assign xmudrii for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Oct 18, 2023
cpanato
cpanato suggested changes Oct 18, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we cannot move those because we use some secrets from gcp and then that makes sense to keep the jobs as is.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2023
saschagrunert
saschagrunert reviewed Oct 19, 2023
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move the secret to the k8s-infra-prow-build cluster?

Which secret are we referring to?

@cpanato
Copy link
Member

cpanato commented Oct 19, 2023

Would it be possible to move the secret to the k8s-infra-prow-build cluster?

Which secret are we referring to?

https://github.com/kubernetes/test-infra/pull/31063/files#diff-02a94ff8e4f303b60c3e34c4f93f0f2bf3f3de91e733461ded97f774b9ecb281L35-L39

do you think worth doing this change?

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 21, 2024
@ameukam
Copy link
Member

ameukam commented Feb 27, 2024

Let's not do this for the moment.
/close

@k8s-ci-robot
Copy link
Contributor

@ameukam: Closed this PR.

In response to this:

Let's not do this for the moment.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert left review comments

@cpanato cpanato cpanato requested changes

@ameukam ameukam Awaiting requested review from ameukam

@jeremyrickard jeremyrickard Awaiting requested review from jeremyrickard

@justaugustus justaugustus Awaiting requested review from justaugustus

@listx listx Awaiting requested review from listx

@puerco puerco Awaiting requested review from puerco

Assignees

@cpanato cpanato

Labels
area/artifacts Issues or PRs related to the hosting of release artifacts for subprojects area/config Issues or PRs related to code in /config area/jobs area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@rjsadow @k8s-ci-robot @cpanato @k8s-triage-robot @ameukam @saschagrunert