Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate ingress-gce jobs to community cluster #31681

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

rjsadow
Copy link
Contributor

@rjsadow rjsadow commented Jan 21, 2024

This PR moves ingress-gce jobs to the community owned cluster gke cluster

ref: #30277

/cc @aojea @bowei @cadmuxe @MrHohn @rramkumar1

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jan 21, 2024
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 21, 2024
@ameukam
Copy link
Member

ameukam commented Jan 25, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ameukam, rjsadow

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit 54415b4 into kubernetes:master Jan 25, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@rjsadow: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key ingress-gce-e2e.yaml using file config/jobs/kubernetes/sig-network/ingress-gce-e2e.yaml

In response to this:

This PR moves ingress-gce jobs to the community owned cluster gke cluster

ref: #30277

/cc @aojea @bowei @cadmuxe @MrHohn @rramkumar1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member

aojea commented Jan 26, 2024

@ameukam these tests run in a specific project and now are broken, can we please revert this @rjsadow so we have the jobs working?

@swetharepakula can you ping me offline to talk about this and a long term solution?

@ameukam
Copy link
Member

ameukam commented Jan 26, 2024

@ameukam these tests run in a specific project and now are broken, can we please revert this @rjsadow so we have the jobs working?

@swetharepakula can you ping me offline to talk about this and a long term solution?

@ameukam these tests run in a specific project and now are broken, can we please revert this @rjsadow so we have the jobs working?

@swetharepakula can you ping me offline to talk about this and a long term solution?

We should work toward making sure the jobs are capable to run on the community infrastructure instead of reverting every time a job is failing.
k8s-infra provided a lot of assistance around job migration.
What are the requirements of those jobs ? we can have this discussion around an issue in k/k8s.io.
What are the specific

@swetharepakula
Copy link
Member

We should be able to migrate, I don't think there are any special requirements of the jobs. We saw that tests were failing because it was unable to acquire a test project to use for the test:

Acquire failed: resource type "ingress-project" does not exist

This tells me the project was hard coded (likely in the ingress-gce tests). Once we fix that, we should be able to use the community cluster.

cc/ @sawsa307

@sawsa307
Copy link
Contributor

sawsa307 commented Jan 29, 2024

We need some guidance regarding the migration. I've created an issue here #31757. @rjsadow @ameukam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants