Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add resizable table columns #2625

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jun 13, 2024

Whilst the feature here is making our table columns resizable, kongponents provides us with this functionality. But kongponents rightly doesn't dictate how you should persist the column sizes once resized.

Therefore the majority of this PR is providing a way application-wide that we can persist and retrieve user preference/settings/values etc. Here we use localStorage but we could just as well switch in a separate set of sources to use something different such as a users session.

I chose to key settings by route name, and after doing so I figured we may as well make all this available via RouteView.

Notes:

  • Adds DataSink, a writing version of DataSource. The most important thing for me here is the interface. The innards of DataSink and how it works under-the-hood will no doubt change, but I don't want to do all that at this stage, only enough for me to add this feature.
  • Moves DataSource:src="/me" into RouteView and then provides RouteView#me via RouteViews slot. I figure every route will potentially need to get/set user persisted values so we may as well make it available via the RouteView rather than have to repeatedly add the DataSource everytime as we do previoius to this PR.
  • I've only done MeshListView for now for proof-of-concept, if I get an initial approval of this, next steps will be to roll this out everywhere.

Part of #2468

Copy link

netlify bot commented Jun 13, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 6b0e270
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/66852477c7d5d80008a853c7
😎 Deploy Preview https://deploy-preview-2625--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen added this to the 2.8.x milestone Jun 13, 2024
@johncowen johncowen self-assigned this Jun 13, 2024
@johncowen johncowen force-pushed the feature/resizable-columns branch 4 times, most recently from 637949f to 1c91bc4 Compare June 18, 2024 15:31
@lahabana lahabana modified the milestones: 2.8.x, 2.9.x Jun 19, 2024
@johncowen johncowen marked this pull request as ready for review June 19, 2024 18:09
@johncowen johncowen requested a review from a team as a code owner June 19, 2024 18:09
@johncowen johncowen changed the title feat: [WIP] add resizable table columns feat: add resizable table columns Jun 19, 2024
Signed-off-by: John Cowen <[email protected]>
@johncowen johncowen merged commit 585c96e into kumahq:master Jul 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants