Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove sub-titling across the application #2710

Merged
merged 1 commit into from
Jul 4, 2024

Conversation

johncowen
Copy link
Contributor

@johncowen johncowen commented Jul 1, 2024

We decided to remove the subtitling across the application, given that in the vast majority of cases the selected tab acts as a title.

We plan on adding an introductory sentence in place of these titles (see #2505) and we might want to make some slight amends to the HTML structure of AppView before doing that, especially seeing as AppView was built against the "old version" of the application and probably considered that being originally built.

Closes #2701

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for kuma-gui ready!

Name Link
🔨 Latest commit 1507da7
🔍 Latest deploy log https://app.netlify.com/sites/kuma-gui/deploys/6682a8edb4b4ca000864ede0
😎 Deploy Preview https://deploy-preview-2710--kuma-gui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@johncowen johncowen marked this pull request as ready for review July 1, 2024 14:33
@johncowen johncowen requested a review from a team as a code owner July 1, 2024 14:33
@johncowen johncowen self-assigned this Jul 1, 2024
@johncowen johncowen added this to the 2.9.x milestone Jul 1, 2024
@johncowen johncowen merged commit dabc56a into kumahq:master Jul 4, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove all subtitles that are underneath tabs
2 participants