Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(merge): release-2.8 branch to master #10668

Closed
wants to merge 2 commits into from

Conversation

kumahq[bot]
Copy link
Contributor

@kumahq kumahq bot commented Jun 28, 2024

Do NOT squash on merging. Allow merge commit first in the repository settings.

Generated by action

kumahq bot and others added 2 commits June 28, 2024 08:16
…10651) (#10662)

fix(cni): set proper namespace for the taint controller (#10651)

* fix(cni): set proper namespace for the taint controller



* fix(cni): use custom namespace



* fix(cni): set namespace in the config



---------

Signed-off-by: slonka <[email protected]>
Co-authored-by: Krzysztof Słonka <[email protected]>
Signed-off-by: kumahq[bot] <110050114+kumahq[bot]@users.noreply.github.com>
slonka
slonka previously requested changes Jun 28, 2024
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't get in, right?

@jakubdyszkiewicz
Copy link
Contributor

why? We said that we are ok with double commits on backported PRs

@slonka slonka dismissed their stale review June 28, 2024 09:48

"We said that we are ok with double commits on backported PRs"

@jakubdyszkiewicz
Copy link
Contributor

closing because of #10708

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants