Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/add preference to set high resolution in multi column mode #22

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Netlighter
Copy link

Add preference to set high resolution in multi column mode

@Netlighter Netlighter changed the title Add preference to set high resolution in multi column mode feat/add preference to set high resolution in multi column mode May 11, 2024
@Netlighter Netlighter changed the title feat/add preference to set high resolution in multi column mode Feat/add preference to set high resolution in multi column mode May 11, 2024
@Netlighter Netlighter changed the title Feat/add preference to set high resolution in multi column mode feat/add preference to set high resolution in multi column mode May 11, 2024
Copy link
Owner

@kurozenzen kurozenzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks for your contribution. I had a quick look on my phone now but sadly I won't have time to try it out until the weekend.

Anyways, I left some minor comments 🙂

@@ -11,7 +11,8 @@ export enum StoreKey {
Theme = 'kurosearch:theme',
AlwaysLoop = 'kurosearch:always-loop',
CookiesAccepted = 'kurosearch:cookies-accepted',
HighResolutionEnabled = 'kurosearch:high-resolution-enabled',
HighResolutionSingleColEnabled = 'kurosearch:high-resolution-single-col-enabled',
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the value of the storekey as it was. Changing the value will effectively reset the preference for all users.

@@ -122,7 +123,7 @@
</div>
</Preference>

<Preference title="Result layout" description="Save active tags and posts between sessions.">
<Preference title="Result layout" description="Change posts grid in result layout.">
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍 thanks for correcting it.

@Netlighter
Copy link
Author

I apologize greatly for being missing for a month as github didn't send notifications. I've made the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants