-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support DDL in manual transaction #3128
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3128 +/- ##
==========================================
- Coverage 91.95% 91.87% -0.08%
==========================================
Files 1168 1167 -1
Lines 44085 44068 -17
==========================================
- Hits 40538 40488 -50
- Misses 3547 3580 +33 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw incomplete logic and duplicated code, make sure you go through changes before requesting review.
Make sure our test coverage for DDL transactions is full under four cases: COMMIT, COMMIT RECOVERY, ROLLBACK, ROLLBACK RECOVERY.
Also, add tests on more cases, at least following ones (the more the better):
- create multiple tables in a single transaction (node and rel tables)
- create node/rel tables, drop node/rel tables in a single transaction
- create tables, and alter tables in a single transaction
default: | ||
return true; | ||
} | ||
static bool allowActiveTransaction(StatementType /*statementType*/) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this a todo for Chang?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related to KUZU_API, affecting python, java, and rust APIs, which I can not handle
see #3062
TODO: