Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compile flag to reduce size of static library on windows #3644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjaminwinger
Copy link
Collaborator

See #2520. This doesn't really fix the issue, but it reduced the size from 583MB to 315MB when I compared release builds with it enabled/disabled (evidently the static library size has gone up since that issue was opened). The static library size on Linux, for reference, is currently about 43MB, so it still seems unnecessarily large.

According to the docs this is disabled by default for command line builds, but enabled by default in visual studio. There don't appear to be any downsides of enabling it (it forces you to define functions inline when they are marked as inline, but we should do that anyway).

Copy link

Benchmark Result

Master commit hash: b0aca6d5e63042ec65080bec372bf0796937856b
Branch commit hash: 4c4120004d51026187f9dcedda198a52d3534412

Query Group Query Name Mean Time - Commit (ms) Mean Time - Master (ms) Diff
aggregation q24 647.58 645.67 1.91 (0.30%)
aggregation q28 11632.56 13939.40 -2306.84 (-16.55%)
filter q14 139.78 136.61 3.17 (2.32%)
filter q15 143.24 133.09 10.14 (7.62%)
filter q16 303.45 306.72 -3.27 (-1.07%)
filter q17 447.85 444.56 3.29 (0.74%)
filter q18 1939.65 1893.70 45.95 (2.43%)
fixed_size_expr_evaluator q07 565.30 563.50 1.80 (0.32%)
fixed_size_expr_evaluator q08 789.75 787.72 2.03 (0.26%)
fixed_size_expr_evaluator q09 787.79 785.99 1.80 (0.23%)
fixed_size_expr_evaluator q10 238.89 239.35 -0.46 (-0.19%)
fixed_size_expr_evaluator q11 234.22 233.28 0.95 (0.41%)
fixed_size_expr_evaluator q12 234.04 232.84 1.20 (0.52%)
fixed_size_expr_evaluator q13 1469.34 1469.26 0.08 (0.01%)
fixed_size_seq_scan q23 114.52 114.83 -0.31 (-0.27%)
join q29 695.26 688.20 7.06 (1.03%)
join q30 1480.36 1517.82 -37.45 (-2.47%)
join q31 46.45 47.35 -0.91 (-1.91%)
ldbc_snb_ic q35 3476.95 3484.49 -7.54 (-0.22%)
ldbc_snb_ic q36 128.54 139.48 -10.94 (-7.85%)
ldbc_snb_is q32 12.74 12.84 -0.10 (-0.75%)
ldbc_snb_is q33 85.91 93.99 -8.08 (-8.60%)
ldbc_snb_is q34 95.39 99.70 -4.31 (-4.32%)
order_by q25 127.12 122.69 4.43 (3.61%)
order_by q26 439.08 440.31 -1.23 (-0.28%)
order_by q27 1397.18 1398.48 -1.31 (-0.09%)
scan_after_filter q01 179.53 175.73 3.80 (2.16%)
scan_after_filter q02 152.35 152.83 -0.48 (-0.31%)
shortest_path_ldbc100 q39 56.12 54.50 1.62 (2.98%)
var_size_expr_evaluator q03 2032.49 2035.60 -3.11 (-0.15%)
var_size_expr_evaluator q04 2229.93 2219.78 10.15 (0.46%)
var_size_expr_evaluator q05 2607.97 2604.98 2.99 (0.11%)
var_size_expr_evaluator q06 1363.72 1368.89 -5.16 (-0.38%)
var_size_seq_scan q19 1446.42 1450.20 -3.78 (-0.26%)
var_size_seq_scan q20 3106.56 3118.33 -11.78 (-0.38%)
var_size_seq_scan q21 2417.71 2396.01 21.70 (0.91%)
var_size_seq_scan q22 129.38 129.97 -0.59 (-0.46%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants