New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wait for callbacks #55

Merged

lancetipton merged 2 commits into main from wait-for-callbacks

Sep 1, 2023

Owner

lancetipton commented Sep 1, 2023 •

edited

Loading

Updates

The test runner currently does not wait for the callbacks to finish
- This causes issues when they are async
- It creates a race condition when the tests finish before the callback does
This PR adds await to all the callbacks, so that the runner will wait until the callbacks complete before moving on to the next test
It also includes tests and fixes for tags

lancetipton added 2 commits

August 31, 2023 18:59


          feat: wait for callbacks to finish before proceeding

5e5fe58


          feat: fix tags and world type

a42be03

lancetipton merged commit 6efa5ef into main

1 check passed

lancetipton deleted the wait-for-callbacks branch

September 1, 2023 02:10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment