chore: move build to tsup, update top level entries, ignore artifacts #62
Conversation
There was a problem hiding this comment.
This repo used to use yarn, but I've recently switched to pnpm. Not sure if there's still a yarn lock file sitting around somewhere that I missed.
If that's the case, my apologies. Let me know if you find it.
That said, can you remove this file from the PR.
Also if you want to add it the .gitignore, you could still use yarn locally and it won't be part of the PR.
There was a problem hiding this comment.
I'm not sure I follow why the /docs files were removed?
They are needed for the demo website => https://lancetipton.github.io/parkin/
But maybe I'm missing something?
I'd be open to removing them here and adding them to a github/pages branch only. Which is then used to pushed to the demo site. It doesn't take much to switch to that pattern, there's a few npm pacakges that help with it as well.
There was a problem hiding this comment.
I have a custom publish cli / cmd that I run locally the uses the /docs and /build files.
I get why you ignored them, but means I probably need to change how new versions are published.
I'm completely open to that, and most likely it would be best to add it as a github action , so it's automated when changes are merged into main.
But until that's added I'd have to figure out a new way to publish the changes to github/pages for the demo site and npm for the package if these files are no longer part of the repo?
Or I'm open to another path if you have something in mind?
There was a problem hiding this comment.
wow, nice. Thank for the work you put into this. I'm not familiar with tsup, but I just looked it up and it looks solid.
I'm definitely open to switching to it. That said, there's a few issues I left comments for in this PR.
But, I'm happy to merge it once those are addressed.
Updates