Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect recognition of data input in chart #4972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

engery
Copy link

@engery engery commented Jun 5, 2024

Description

The original logic, when processing data such as 12, 23, 34; 230,340,540, the original code will first follow the ";" After splitting, mistakenly taking 12, 23, and 34 as one number for judgment; I made the modifications and will start with ';' After splitting, first perform ',' and then perform int and float judgments to avoid this problem!

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

I ran locally and tested different situations, such as when the data is one group or multiple groups.

  • TODO

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 5, 2024
@crazywoola crazywoola requested a review from Yeuoly June 5, 2024 14:45
@crazywoola
Copy link
Member

Please fix the lint error in this pr.

@bowenliang123
Copy link
Contributor

Sorry that I still fail to understand the key point of the supposed fixes.
Any comparison in parsing outputs for the without or with this fixes?

@Yeuoly
Copy link
Collaborator

Yeuoly commented Jun 7, 2024

I guess you are trying to enable the drawing of multiple lines on the same chart, it makes sense, but you should update the description of data as LLM should be informed that how to generate the data you want, but also, human_description needs to be optimized, otherwise, developers are confused

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants