Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libssh test fix #412

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Libssh test fix #412

merged 2 commits into from
Jul 9, 2024

Conversation

Jakuje
Copy link
Contributor

@Jakuje Jakuje commented Jul 4, 2024

Description

Minor fixes to the libssh integration test

Reviewer's checklist:

  • Any issues marked for closing are addressed
  • There is a test suite reasonably covering new functionality or modifications
  • This feature/change has adequate documentation added
  • Code conform to coding style that today cannot yet be enforced via the check style test
  • Commits have short titles and sensible commit messages
  • Coverity Scan has run if needed (code PR) and no new defects were found

Signed-off-by: Jakub Jelen <[email protected]>
@Jakuje Jakuje requested a review from The-Mule July 4, 2024 17:15
@Jakuje
Copy link
Contributor Author

Jakuje commented Jul 4, 2024

sigh ... sounds like the engine.h is included in two places but we removed only one. Will fix with another MR on libssh side.

@Jakuje
Copy link
Contributor Author

Jakuje commented Jul 4, 2024

Pushed in here with some more assorted stuff:
https://gitlab.com/libssh/libssh-mirror/-/merge_requests/509

@@ -47,7 +47,7 @@ pkcs11_provider_setup()

libssh_setup()
{
title PRAM "Clone, setup and build libssh"
title PARA "Clone, setup and build libssh"

git clone https://gitlab.com/libssh/libssh-mirror.git \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also fix the link please?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This git forge is running on some Andreas servers. I do not know how much traffic the cloning from CI is going to generate so I would prefer to keep the gitlab mirror as that is automatically updated every hour or so and is more likely to be present.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, yes, that makes sense, please disregard my comment :). It looks like this mirror is up to date.

Copy link
Member

@simo5 simo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simo5
Copy link
Member

simo5 commented Jul 9, 2024

With recent rebuild of gnutls in rawhide now all tests pass, so this is finally fixed.
Merging

@simo5 simo5 merged commit b0e23ce into latchset:main Jul 9, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants