Optimized Tensors #167
Optimized Tensors #167
Conversation
|
@zivmo99 |
|
@dolby360 |
leondavi
force-pushed
the
nerlTensor
branch
2 times, most recently
from
13cdc4d
to
3237bc7
Compare
leondavi
force-pushed
the
nerlTensor
branch
3 times, most recently
from
547277c
to
d897ca1
Compare
|
@halfway258 please approve that this PR works fine. |
There was a problem hiding this comment.
@halfway258
This is the generic file that contains useful methods.
src_erl/erlBridge/nerlTests.erl
Outdated
There was a problem hiding this comment.
@halfway258 nerlTests .erl implementation
|
|
||
| COMPILE_FILES="$COMPILE_NERL,$COMPILE_NERLNIF,$COMPILE_NERLTEST" | ||
|
|
||
| erl -noshell -eval "$COMPILE_FILES, nerlTests:run_tests()." -s init stop > "$NERLNET_TEST_DIR/$LOG_FILE" |
There was a problem hiding this comment.
@dolby360
Here is the calling to nerlTests module
If you want to get some kind of exception to see if action fails you just can change it as follows:
"$COMPILE_FILES, throw(check), nerlTests:run_tests()."
leondavi
force-pushed
the
nerlTensor
branch
5 times, most recently
from
a2f74e6
to
894384f
Compare
| } | ||
|
|
||
|
|
||
| template<typename BasicType> void get_tensor_data(ErlNifEnv *env , ERL_NIF_TERM bin_term, std::vector<BasicType> &data, std::vector<BasicType> &dims_orig, std::vector<int> &dims) |
There was a problem hiding this comment.
Should change to
get_tensor(ErlNifEnv *env , ERL_NIF_TERM bin_term, TensorTypePtr &tensor_ptr)
Rowmajor binary map to rowmajor tensor swap to colmajor tensor
make_tensor(ErlNifEnv *env , nifpp::TERM &out_bin_term, TensorTypePtr &tensor_ptr)
convert colmajor --> rowmajor --> binary
| end. | ||
|
|
||
|
|
||
| tic() -> erlang:timestamp(). |
There was a problem hiding this comment.
erlang has a function that does this: {TimeTook, ReturnVal} = timer:tc(M, F, A)
|
I ran the tests, all good |
Please run it again with my latest push (on raspberry pi as well) just to make sure and approve this PR |
- TODO implement the encode_nif function Helpful link: https://stackoverflow.com/questions/9521854/creating-a-erlang-binary-through-nif-with-data-pointing-to-a-char
Remained tasks: - decode_eigen_tensor - check nif
Encode works Decode WIP
TODO - Create test for conversion - Complete cpp implementation of decode_bin_to_eigen_tensor method
|
Test on raspberry pi passed: |
@zivmo99
Hi Ziv,
Please implement encode_nif
Please review my implementation in both erl files and cpp especially
decode_nif, get_binary methods.
Thanks
Note: This should be merged only after the PR of onn600!