Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'form' attribute for <mo> MathML element #2660

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

lnay
Copy link

@lnay lnay commented Jun 30, 2024

Although this attribute seems to be missing in the attribute table on Mozilla Docs for that tag ,
it does appear in the compatibility table lower down.
This attribute is also frequently used by temml, a common generator for MathML content.

WARNING: I haven't set up a dev or test env, and hoping this this can be picked up by somebody else as a quick fix if what I did was incorrect.

Mainly doing this to raise awareness of the issue.

This attribute seems to be missing in the attribute
table on Mozilla Docs, however does appear in the
compatibility table lower down.
This attribute is also frequently used by temml,
a common generator for mathml content.
@lnay
Copy link
Author

lnay commented Jun 30, 2024

I ran cargo make check && cargo make test && cargo make check-examples,
failing with identical errors as when I run it on the current head of the leptos_0.7 branch:

error[E0412]: cannot find type `SerdeLite` in this scope
   --> leptos_server/src/resource.rs:161:24
    |
161 | impl<T> ArcResource<T, SerdeLite>
    |                        ^^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
161 | impl<T, SerdeLite> ArcResource<T, SerdeLite>
    |       +++++++++++

error[E0412]: cannot find type `SerdeLite` in this scope
   --> leptos_server/src/resource.rs:163:33
    |
163 |     T: Debug + SerializableData<SerdeLite>,
    |                                 ^^^^^^^^^ not found in this scope
    |
help: you might be missing a type parameter
    |
161 | impl<T, SerdeLite> ArcResource<T, SerdeLite>
    |       +++++++++++

error[E0277]: the trait bound `T: SerializableData<_>` is not satisfied
   --> leptos_server/src/resource.rs:176:9
    |
176 |         ArcResource::new_with_encoding(source, fetcher)
    |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `SerializableData<_>` is not implemented for `T`
    |
    = help: the following other types implement trait `SerializableData<Ser>`:
              <T as SerializableData<SerdeJson>>
              <T as SerializableData<rkyv::Rkyv>>
              <T as SerializableData<serializers::Str>>
note: required by a bound in `ArcResource::<T, Ser>::new_with_encoding`
   --> leptos_server/src/resource.rs:183:16
    |
183 |     T: Debug + SerializableData<Ser>,
    |                ^^^^^^^^^^^^^^^^^^^^^ required by this bound in `ArcResource::<T, Ser>::new_with_encoding`
...
187 |     pub fn new_with_encoding<S, Fut>(
    |            ----------------- required by a bound in this associated function

@gbj
Copy link
Collaborator

gbj commented Jul 1, 2024

Thank you thank you! CI is in a broken state at present for the core packages and that's fine, I appreciate the diligence and the PR.

@gbj gbj merged commit a83e5fa into leptos-rs:leptos_0.7 Jul 1, 2024
@gbj
Copy link
Collaborator

gbj commented Jul 1, 2024

Also super glad to see someone using MathML, and glad we have built-in support for it :-)

@lnay
Copy link
Author

lnay commented Jul 1, 2024

Thanks, I've experienced quirks with MathML in other frameworks and glad to see its support in leptos 0.7.

Leptos has been a really good fit so far for packaging a mathematical Rust crate into both a Python/SageMath library as well as a WebApp for exposure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants