Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cpu profiling with rule #2978

Merged
merged 2 commits into from
Jul 8, 2024

Conversation

Rookiecom
Copy link

No description provided.

Copy link
Collaborator

@Yisaer Yisaer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

internal/conf/conf.go Outdated Show resolved Hide resolved
etc/kuiper.yaml Outdated Show resolved Hide resolved
@Yisaer Yisaer requested a review from ngjaying July 3, 2024 03:50
Copy link

codecov bot commented Jul 3, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-v2@ed7bd5b). Learn more about missing BASE report.

Files Patch % Lines
internal/server/server.go 55.56% 7 Missing and 1 partial ⚠️
internal/server/pprof_init.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2978   +/-   ##
============================================
  Coverage             ?   68.17%           
============================================
  Files                ?      339           
  Lines                ?    32959           
  Branches             ?        0           
============================================
  Hits                 ?    22468           
  Misses               ?     8480           
  Partials             ?     2011           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ngjaying ngjaying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rookiecom Thanks! Basically,test coverage should be more than 70%

@Rookiecom Rookiecom force-pushed the introduce_cpu_info2 branch 2 times, most recently from d52e20a to c080089 Compare July 3, 2024 20:15
@Rookiecom Rookiecom force-pushed the introduce_cpu_info2 branch 6 times, most recently from c292e64 to f64737f Compare July 7, 2024 18:20
@Yisaer Yisaer requested a review from ngjaying July 8, 2024 03:44
@ngjaying ngjaying merged commit 1377414 into lf-edge:master-v2 Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants