Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: let reload connection have timeout #2988

Merged
merged 3 commits into from
Jul 8, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 5, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying July 5, 2024 03:40
Signed-off-by: Song Gao <[email protected]>
Signed-off-by: Song Gao <[email protected]>
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.20%. Comparing base (e82fe62) to head (db4324a).
Report is 4 commits behind head on master-v2.

Files Patch % Lines
internal/server/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           master-v2    #2988      +/-   ##
=============================================
+ Coverage      68.15%   68.20%   +0.04%     
=============================================
  Files            338      339       +1     
  Lines          32857    32948      +91     
=============================================
+ Hits           22393    22469      +76     
- Misses          8455     8465      +10     
- Partials        2009     2014       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit e1ff51d into lf-edge:master-v2 Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants