Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ws client #2992

Merged
merged 1 commit into from
Jul 8, 2024
Merged

feat: support ws client #2992

merged 1 commit into from
Jul 8, 2024

Conversation

Yisaer
Copy link
Collaborator

@Yisaer Yisaer commented Jul 8, 2024

No description provided.

Signed-off-by: Song Gao <[email protected]>
@Yisaer Yisaer requested a review from ngjaying July 8, 2024 05:53
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 86.51685% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (master-v2@f17f544). Learn more about missing BASE report.

Files Patch % Lines
internal/io/http/httpserver/websocketConn.go 79.31% 3 Missing and 3 partials ⚠️
internal/io/http/httpserver/websocket_client.go 88.57% 2 Missing and 2 partials ⚠️
internal/io/websocket/websocket_source.go 71.43% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master-v2    #2992   +/-   ##
============================================
  Coverage             ?   68.20%           
============================================
  Files                ?      340           
  Lines                ?    32989           
  Branches             ?        0           
============================================
  Hits                 ?    22497           
  Misses               ?     8473           
  Partials             ?     2019           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ngjaying ngjaying merged commit 461b48b into lf-edge:master-v2 Jul 8, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants