Added color to bold selection style. #2324
Conversation
Could you add this idea to the rfc? |
|
I see this more as a step towards getting this PR merged without breaking anything, before we agree on a roadmap in the RFC. Think of it as a feature flag. |
| @@ -292,6 +292,7 @@ public List<SynthesisOption> getDisplayedSynthesisOptions() { | |||
| ModeDiagrams.INITIALLY_COLLAPSE_MODES, | |||
| SHOW_USER_LABELS, | |||
| SHOW_HYPERLINKS, | |||
| LinguaFrancaStyleExtensions.SELECTION_HIGHLIGHTING_COLOR, | |||
There was a problem hiding this comment.
I ordered the selection highlighting option below the more visual synthesis options. Feel free to comment on this
| @@ -76,6 +78,12 @@ public class LinguaFrancaStyleExtensions extends AbstractSynthesisExtensions { | |||
| @Inject @Extension private KPolylineExtensions _kPolylineExtensions; | |||
| @Extension private KRenderingFactory _kRenderingFactory = KRenderingFactory.eINSTANCE; | |||
|
|
|||
| public static final String SELECTION_HIGHLIGHTING_COLOR_LABEL = "Selection Coloring"; | |||
There was a problem hiding this comment.
I propose this label for the synthesis option.
| public static final SynthesisOption SELECTION_HIGHLIGHTING_COLOR = | ||
| SynthesisOption.createCheckOption(SELECTION_HIGHLIGHTING_COLOR_LABEL, false) | ||
| .setCategory(LinguaFrancaSynthesis.APPEARANCE); | ||
|
|
There was a problem hiding this comment.
Currently, the new synthesis option is in the appearance category and its default value is false such that it will not break things but can be enabled.
| // Improve this with content from https://github.com/lf-lang/rfcs/pull/3 | ||
| boolean selectionColor = getBooleanValue(SELECTION_HIGHLIGHTING_COLOR); | ||
| if (selectionColor) { | ||
| _kRenderingExtensions.setSelectionForeground(r, Colors.ORANGE_1); | ||
| } |
There was a problem hiding this comment.
Simply add the selection foreground rendering to renderings if the synthesis option is enabled.
This solution should be improved once the discussion in RFC 3 lf-lang/rfcs#3 completes.