Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render selected PDF pages only #23

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Render selected PDF pages only #23

merged 2 commits into from
Feb 13, 2024

Conversation

t29mato
Copy link
Collaborator

@t29mato t29mato commented Feb 9, 2024 •
edited
Loading

Original Issue

#22

Test case

  • Annotations are correctly displayed in cases like 'None', '1,3', '2,4', '1,3,5' in multi-page PDFs.

Test environment

It uses structure-vision
lfoppiano/structure-vision#1

@t29mato t29mato assigned t29mato and lfoppiano and unassigned t29mato Feb 9, 2024
@t29mato t29mato added the enhancement New feature or request label Feb 9, 2024
@lfoppiano lfoppiano changed the title Add feature to render selected PDF pages only Render selected PDF pages only Feb 9, 2024
@lfoppiano
Copy link
Owner

The related issue is #22 isn't it?

@t29mato
Copy link
Collaborator Author

t29mato commented Feb 10, 2024

The related issue is #22 isn't it?

Thank you for letting me know.
Yes, it's supposed to be #22
I've updated it.

@lfoppiano
Copy link
Owner

Here the visualised PDF is only the selection. How about scrolling down to the selected page?

lfoppiano
lfoppiano requested changes Feb 13, 2024
View reviewed changes
Copy link
Owner

@lfoppiano lfoppiano left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the related documentation in the readme.md?

@t29mato
Copy link
Collaborator Author

t29mato commented Feb 13, 2024

Could you add the related documentation in the readme.md?

I've updated it.

@lfoppiano lfoppiano merged commit 667495f into main Feb 13, 2024
5 checks passed
@lfoppiano lfoppiano deleted the feature/selective-pdf-rendering branch February 13, 2024 10:05
@lfoppiano lfoppiano added this to the 0.0.6 milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfoppiano lfoppiano lfoppiano approved these changes

Assignees

@lfoppiano lfoppiano

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.0.6
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@t29mato @lfoppiano