Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GossipSub 1.2] PING/PONG control messages #558

Draft
wants to merge 3 commits into
base: gossipsub/v1.2
Choose a base branch
from
Draft

[GossipSub 1.2] PING/PONG control messages #558

wants to merge 3 commits into from

Conversation

Nashatyrev
Copy link
Contributor

@Nashatyrev Nashatyrev commented Jul 13, 2023 •
edited
Loading

This PR introduces a new GossipSub version 1.2

Co-authored with @Menduist

New messages

The new PING/PONG control messages are added

Potential applications:

  • Emulate message receive acknowledgement for better staggered sending
  • Help gossip router to gather additional statistics about connection characteristics (e.g. latency and bandwidth) and optimize message sending (send staggering mostly)
  • Additionally that could potentially be used to keep TCP connection 'warm' (avoid TCP slow start restart) by sending quite frequent PING requests (with a period of 1-2 RRTs)

@vyzo vyzo mentioned this pull request Jul 14, 2023
Draft
@vyzo
Copy link
Contributor

vyzo commented Jul 14, 2023

Let's target this to #560

@Nashatyrev Nashatyrev changed the base branch from master to gossipsub/v1.2 July 17, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
libp2p Specs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nashatyrev @vyzo