[GossipSub 1.1] Limit the size of PRUNE Peer Exchange list #576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nashatyrev
changed the title
|
If to disable the feature we need to set the parameter to |
|
@Nashatyrev how about making |
I don't know actually. There was a reason why this feature was added I believe. And it seems a bit weird having a feature in the spec which is disabled by default. |
|
It seems that was the intention as mentioned here #570 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment the
ControlPrune.peerslist is not limited by any boundary.This PR suggests to add the
MaxExchangePeersparameter for that.Instead of hardcoding a 'reasonable default' I'd suggest to parametrize it mostly to have the ability to turn off this feature (by setting this parameter to
0).See also this issue: ethereum/consensus-specs#3500