OER: fix empty length decoding, no zero padding allowed #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This now needs to be rebased to resolve conflicts. |
Nicceboy
force-pushed
the
oer-zero-length-fix
branch
from
6925229
to
d941d7b
Compare
|
Rebased |
|
Thank you for your PR! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a logic bug when parsing zero padding and there was no length.
That was a cause for null string in #272 instead of None.
But after consulting the standard again, I think zero padding is not allowed even in OER in this case and whole function can be removed.
Zeros are allowed in long format.