-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing styling issue with friends list and opponents #15560 #15562
base: master
Are you sure you want to change the base?
fixing styling issue with friends list and opponents #15560 #15562
Conversation
…ext translations as alt attributes instead of text elements
broken by #15260 |
…ng the text translations as alt attributes instead of text elements" This reverts commit 2c2b52b.
… shown via paged results
I updated the PR so the translated text is still added if shown on paginated results. ![]() ![]() |
@@ -51,7 +60,7 @@ final class Relation(env: Env, apiC: => Api) extends LilaController(env): | |||
env.msg.api.postPreset(me, msg) >> rateLimited(msg.name) | |||
else | |||
api.follow(me, user.id).recoverDefault >> negotiate( | |||
renderActions(user.name, getBool("mini")), | |||
renderActions(user.name, getBool("mini"), getBool("showText")), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?? Why is showText
read from the HTTP request query parameters?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In my initial fix I had not realised that when toggling e.g. follow/unfollow the text captions would re-appear as logic at runtime would not have the info if presented for paginated results or single user. Looking at the approach done for mini layout of the relation UI, I copied that approach.
Perhaps I could also attempt fixing this via introducing some additional routes?
e.g (/api/rel/follow/${user}/partial)
fixing styling issue with friends list and opponents by setting the text translations as alt attributes instead of text elements